docker-pi-hole icon indicating copy to clipboard operation
docker-pi-hole copied to clipboard

ADD padd.sh

Open PromoFaux opened this issue 2 years ago • 5 comments

Description

Simple really, adds https://github.com/pi-hole/padd into the container

Motivation and Context

We started an internal discussion, and then I did this.

How Has This Been Tested?

docker exec -it pihole ./padd.sh

padd

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.

PromoFaux avatar May 26 '22 19:05 PromoFaux

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar May 26 '22 19:05 sonarcloud[bot]

🎗️ Reminder for me: update README in https://github.com/pi-hole/PADD/pull/208 again when this PR is finished.

thomasmerz avatar Aug 12 '22 10:08 thomasmerz

I've not forgotten about this, just not 100% how I want to achieve the end result.

Another thought that has crossed my mind is adding the download of PADD into the container startup, so that it is always up to date

PromoFaux avatar Aug 17 '22 17:08 PromoFaux

Another thought that has crossed my mind is adding the download of PADD into the container startup, so that it is always up to date

I think this is a very good idea. It will avoid the need of updating the docker image each time PADD is updated.

rdwebdesign avatar Aug 18 '22 20:08 rdwebdesign

Do we need the whole repo? Maybe it would be better to copy just the script using wget. What do you think?

rdwebdesign avatar Aug 26 '22 23:08 rdwebdesign

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar Dec 11 '22 16:12 sonarcloud[bot]