docker-pi-hole
docker-pi-hole copied to clipboard
ADD padd.sh
Description
Simple really, adds https://github.com/pi-hole/padd into the container
Motivation and Context
We started an internal discussion, and then I did this.
How Has This Been Tested?
docker exec -it pihole ./padd.sh
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist:
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
🎗️ Reminder for me: update README in https://github.com/pi-hole/PADD/pull/208 again when this PR is finished.
I've not forgotten about this, just not 100% how I want to achieve the end result.
Another thought that has crossed my mind is adding the download of PADD into the container startup, so that it is always up to date
Another thought that has crossed my mind is adding the download of PADD into the container startup, so that it is always up to date
I think this is a very good idea. It will avoid the need of updating the docker image each time PADD is updated.
Do we need the whole repo?
Maybe it would be better to copy just the script using wget
. What do you think?