FTL icon indicating copy to clipboard operation
FTL copied to clipboard

Network Overview - obtain MAC and hostname from dhcp.leases

Open rrobgill opened this issue 4 weeks ago • 0 comments

What does this PR aim to accomplish?:

Allow the Network Overview to be populated by data from the dhcp leases when Pi-hole is acting as the DHCP server in cases that the ARP cache does not contain details.

How does this PR accomplish the above?:

Insert option to search dhcp.leases for client details.

This only occurs if Pi-hole is the dhcp server, and if there is no mac address available from arp cache or recent EDNS records. If no dhcp lease record is present it hands over to the existing mock-hwaddr code.

The search only runs the first time the IP is seen. Once the entry is populated it will not search the file again.

Link documentation PRs if any are needed to support this PR:

N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • [ ] I have read the above and my PR is ready for review. Check this box to confirm

rrobgill avatar Nov 26 '25 21:11 rrobgill