pi
pi copied to clipboard
pi-engine
Finish user module
- improve design
- add user dashborad https://github.com/pi-engine/guide/issues/594
- little improve admin
USER MODULE DASHBOARD
Nice addition, now we have to improve
1/ See My Profile Link
- actually it is linked to user/dashboard instead of user/profile
- add link to user/dashboard when click on avatar
- add link to user/profile when click on View my profile
- add side-menu in user-profile page
- user/profile is usefull, but need some redesign or improvement (maybe header color improvement)
2/ user/dashboard
- module icon would be better for understanding (here it's all Home Dasboard icon)
- sponsor has to be hidden if OFF (use gift icon for sponsor)
3/ put back notification counters ON the icon,not aside
- and no counter if value == 0
4/ support module
- fix side-menu display
5/ user register default redirect
- we have to redirect once registred to user/dashboard instead of user/profile
- and check all redirect in code that redirect to user/profile. Default must be user/dashboard
SYSTEM MODULE / USER BAR
6/ for User Bar , the new option display icon only or icone+title is good
But i need the hybrid way, that hightlights uncommon service modules
- no title for notification/message only (everyone knows the message + notification icons, no need of a title)
- avatar on right with dropdown to logout
- no color background for dropdown, and dropdown is only on avatar+logout (google+ like)
- welcome Firstname must be more visible (for sure add space on left/right)
7/ Display FirstName on front instead of full name
Is it nickname actually?
DressUp User Dashboard and all Manage pages
- it's not possible to dress up the user module dashboard page : something needs to be fixed we have to find a way to let admin organize content on User Dashboard side
User bar main link
- actually it is on Guide Manage : perhaps add a setting, someone will need to open in User Dashboard
avatar in userbar
- it is too small, must be rounded too
@Marc tu peux vérifier le Firstname ? Chez moi c'est toujours un peu compliqué de tester à cause de mon bug en base de données. Le reste est fait en principe, à quelques détails près / à discuter
Ok , I will wait to your push just I have plan to merge dashboard and private profile on user/profile/index , than when user click on www.pi.com/user/profile see his dashboard and when clock on www.pi.com/user/profile/1 see public profile
we worked yesterday on it, we will finish few areas (https://github.com/pi-engine/guide/issues/874)
Now we have to deal with this below, but it has impact on each modules
DressUp User Dashboard and all Manage pages
- we have to find a way to let admin organize content on User Dashboard side,
- it's not possible to dress up the user module dashboard page : adding dashboard page in dressup page is not complicated to make, but...
- actually side-menu is not a block, and is displayed in content module area
- adding it has impact on all modules : must find a way to display side-menu automatically when developing a dashboard page or any side user page with 'add/edit content'
User bar main link
- actually it is on Guide Manage : as soon as we made the block issue, we will be able to move the link : it's important owner see directly what is important without having to digg into several pages.
just I have plan to merge dashboard and private profile on user/profile/index , than when user click on www.pi.com/user/profile see his dashboard and when clock on www.pi.com/user/profile/1 see public profile
you will kill the switch? we made some turnaround, but i'm not satisfied yet. we need to find a way for him to see how is own public profile looks like
you will kill the switch? we made some turnaround, but i'm not satisfied yet. we need to find a way for him to see how is own public profile looks like
perhaps better keep this part for next version , we will talk better about it after some test on active websites
yes, that was my intent too, we will tweek today with Fred what we made yestesday the most important part is the block area, we need to think about this and improve core on it
we have two problem here :
- You use first_name , but this is custom field and not available on many websites and fresh installation , than we have blank page and route error , need remove it from user-bar
- avatar size is to large than header is set big and deform
we will check tomorrow these issues we improved today, we will also tomorrow, here is the result how it must look like with block dressing. we will work further on User Module : display passwd rules on register form, and kill GET redirects
I see you add some guide options on dashboard , I think perhaps its good if we have Api/Dashboard class on each module and dashboard template than on user module we just call dashboard class if module install and class exist , than we can make dynamic load for all modules on user dashboard,
add it is very easy and I think its can be useful , what is your idea ? @Marc-pi @esprit-dev
yes, as told yesterday here, we need 3 things : 1/ have a welcome page in each module : dashboard page 2/ permit admin to compose any webpages with blocks on "owner/user private side" (page dressup) 3/ permit the dev to force side-menu in some pages : ex Manage page for instance (just an example)
Actually, user/dashboard content is displayed in the content area, so we cannot add block easily (in our POC/DEMO, the guide latests bookings -should be made as block-
1/ seems it is what you are thinking about : dahsboard page must be mandatory for any module that has a "private user side" 2/ it's already possible in mymodule/config/page. But some page have no content, only blocks like Dashboard page. 3/ need a param for page.php, to associate for any page automatically the side-menu - by default - as block, but admin can rearrange if he wants to (make the page dress up like everywhere else in Pi) I don't know how we can default a block withing a page...
makes sense? with this, it is more flexible and it is block everywhere in some user private pages
@esprit-dev @voltan @taiwen
we need decide, dress-up dashboard page by block or use API, I vote to use block, than we have to make side-bar block ( its easy ) and user top-bar block ( its easy too ) and block for each module , than we can dress-up user dashboard.
for start and for this version of pi , on core we just have user dashboard page , we can dress-up just this page by block and at this moment for other user pages keep old method
we can work on other modules after this , if agree we can start it
I vote to use block
YESSSSS. let's use Pi Core at its best
for start and for this version of pi , on core we just have user dashboard page , we can dress-up just this page by block
YESSSS
My target is to be able to build on demand such dashboard pages, and let's dream, let user rearrange the blocks for his dashboard or add some.
Must be block :
- side-menu
- shortcuts and of course
- latest bookings
- guide Contribute and Add Paid item dropdown
btw, Comment module is missing in the shortcuts
Than we can start work on this part , I do it or frederic ? I can work on this part tomorrow
Just sidebar and shortcuts is core module blocks , I work on this two other modules like video / guide / fivorite and .... can have custom block
we will today "blockise" latest booking request in guide yes, sidebar and shortcuts are core blocks yes, modules have default block, but we can build custom blocks also
if you can take care about core blocks (don't forget to add comment, we added yesterdays guide/favourite) :
- add side-menu block
- add shortcuts block
- add dashboard in page.php to permit dressup
we will during that time take care about User Register (display password rules) and kill GET redirects (login /register as a modal).
yes, modules have default block, but we can build custom blocks also
We need build some blocks for each module to load on user dashboard
if you can take care about core blocks (don't forget to add comment, we added yesterdays guide/favourite) :
I will work
Just what about this page www.pi.com/user/profile ? we can marge it to user dashboard or keep it now,
and what about top-bar , keep its as block too?
user, keep user/profile as is, we fixed yesterday things on it.
We will have to improve it (you can have a look at airnbn https://www.airbnb.fr/users/show/32967501. In fact, it is your Person item type of .... Guide module :-)
Top bar is ok (you mean userbar i guess???), we improved it yesterday too.
Top bar is ok (you mean userbar i guess???), we improved it yesterday too.
I think about top bar , add it as static code on template of add it as block to can dress-up ?
user, keep user/profile as is, we fixed yesterday things on it.
I have plan to set this part as block to and add it on user dashborad and remove user/profile page , but not know , first finish this parts after that talk about it
what top bar? please add a screenshot
user/profile :
I have plan to set this part as block to and add it on user dashborad and remove user/profile page , but not now , first finish this parts after that talk about it
personally, this user/profil is ok, i would prefer to be able to edit all my info in this page (in a way like in FB). Actually we have a huge submenu list, i'm sure we can simplify it a little bit ...
but let's keep this for later on, we have to think
hum, we already have avatar everywhere (userbar and side-menu). i propose you to let this for later on (with the user/profile stuff), ok?
don't forget to keep the matchheight class we added in Shortcut new Block, to be fully responsive (css flexbox)
You use first_name , but this is custom field and not available on many websites and fresh installation , than we have blank page and route error , need remove it from user-bar
Can you reproduce again ? first_name is used first only if available (isset condition), and name is used instead if needed. Perhaps "name" is also a custom field ?
When pi installed , core_user tables created , on this table we have name field , but I add custom field list on /usr/custom/module/user/config/user.php.order like first name , than for have this fields , need re name user.php.order => user.php and module.php.dist => module.php , than can install user module and have this fields as custom fields on user module
We need still use just name field yet , or add check option to see first_name is exist or not