phys2bids icon indicating copy to clipboard operation
phys2bids copied to clipboard

Generate graphic reports for phys2bids outputs

Open me-pic opened this issue 10 months ago • 10 comments

Closes #131, #407

The PR solved the issues in #407 with the proposed changes mentioned below. The PR #407 was itself a follow-up of #243

Proposed Changes

  • Restrict bokeh version
  • Match bokehJS version to bokeh version
  • Remove x axes constraints

Change Type

  • [ ] bugfix (+0.0.1)
  • [x] minor (+0.1.0)
  • [ ] major (+1.0.0)
  • [ ] refactoring (no version update)
  • [ ] test (no version update)
  • [ ] infrastructure (no version update)
  • [ ] documentation (no version update)
  • [ ] other

Checklist before review

  • [x] I added everything I wanted to add to this PR.
  • [x] [Code or tests only] I wrote/updated the necessary docstrings.
  • [x] [Code or tests only] I ran and passed tests locally.
  • [ ] [Documentation only] I built the docs locally.
  • [x] My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • [x] My code respects the adopted style, especially linting conventions.
  • [x] The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • [x] I added or indicated the right labels.
  • [x] I added information regarding the timeline of completion for this PR.
  • [ ] Please, comment on my PR while it's a draft and give me feedback on the development!

me-pic avatar Apr 18 '24 20:04 me-pic

Codecov Report

Attention: Patch coverage is 98.78049% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.72%. Comparing base (02cf7c6) to head (4c77eca).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
+ Coverage   91.15%   91.72%   +0.57%     
==========================================
  Files           8        9       +1     
  Lines        1006     1088      +82     
==========================================
+ Hits          917      998      +81     
- Misses         89       90       +1     
Files Coverage Δ
phys2bids/cli/run.py 96.55% <100.00%> (+0.12%) :arrow_up:
phys2bids/phys2bids.py 87.36% <100.00%> (+0.20%) :arrow_up:
phys2bids/reporting/html_report.py 98.71% <98.71%> (ø)

codecov[bot] avatar Apr 18 '24 20:04 codecov[bot]

@me-pic this is awesome!!! Can you look into the readthedocs failure, please?

smoia avatar Apr 18 '24 21:04 smoia

@smoia Not sure exactly what is happening with the doc... Been able to build it locally without any error using sphinx-build. Any hint on what I could check ?

me-pic avatar Apr 19 '24 14:04 me-pic

No idea - I think it's happening also in #462. It seems to be something about the phys2bids.phys2bids module import?

smoia avatar Apr 19 '24 16:04 smoia

@me-pic probably the best option is to update the documentation configuration (as well as sphinx packages version). Maybe we can open a new PR, trying to fit phys2bids docs into nigsp's configuration (it's more recent): https://github.com/MIPLabCH/nigsp/tree/master/docs

smoia avatar Apr 19 '24 16:04 smoia

@smoia Thank you ! Will take a look next week.

me-pic avatar Apr 22 '24 14:04 me-pic

@me-pic do you still have problems with the docs?

smoia avatar Oct 08 '24 08:10 smoia

@smoia Yes.. I can't figure why, and I don't have any problem building it locally :(

me-pic avatar Oct 09 '24 14:10 me-pic