phys2bids icon indicating copy to clipboard operation
phys2bids copied to clipboard

Generate report with phys2bids outputs

Open eurunuela opened this issue 3 years ago • 2 comments

Closes #131

This is a follow-up of #243 as the branch on that PR got deleted.

Proposed Changes

  • Adds the functionality to generate a report with phys2bids outputs when requested through the CLI interface or the Python function in phys2bids.py.

Change Type

  • [ ] bugfix (+0.0.1)
  • [x] minor (+0.1.0)
  • [ ] major (+1.0.0)
  • [ ] refactoring (no version update)
  • [x] test (no version update)
  • [ ] infrastructure (no version update)
  • [ ] documentation (no version update)
  • [ ] other

Checklist before review

  • [ ] I added everything I wanted to add to this PR.
  • [x] [Code or tests only] I wrote/updated the necessary docstrings.
  • [x] [Code or tests only] I ran and passed tests locally.
  • [ ] [Documentation only] I built the docs locally.
  • [x] My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • [x] My code respects the adopted style, especially linting conventions.
  • [x] The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • [x] I added or indicated the right labels.
  • [ ] I added information regarding the timeline of completion for this PR.
  • [ ] Please, comment on my PR while it's a draft and give me feedback on the development!

eurunuela avatar Jun 24 '21 10:06 eurunuela

Codecov Report

Merging #407 (d449661) into master (7369827) will increase coverage by 0.34%. The diff coverage is 98.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   94.81%   95.15%   +0.34%     
==========================================
  Files           8        9       +1     
  Lines         868      950      +82     
==========================================
+ Hits          823      904      +81     
- Misses         45       46       +1     
Impacted Files Coverage Δ
phys2bids/reporting/html_report.py 98.71% <98.71%> (ø)
phys2bids/cli/run.py 96.66% <100.00%> (+0.11%) :arrow_up:
phys2bids/phys2bids.py 88.33% <100.00%> (+0.19%) :arrow_up:

codecov[bot] avatar Jun 24 '21 10:06 codecov[bot]

As of right now, the plots don't get loaded. I checked and tedana is not restricting the Bokeh version and we are doing the same. So, I'd say the issue is not related to the version of Bokeh.

eurunuela avatar Jun 24 '21 10:06 eurunuela