phys2bids icon indicating copy to clipboard operation
phys2bids copied to clipboard

Add Main Reviewer checklist

Open smoia opened this issue 5 years ago • 7 comments
trafficstars

Closes none, depends on #315

This is a draft because I'm not totally sure the workflow is right.

Proposed Changes

  • Add a GH Action to create comment addressing the main reviewer when a PR gets assigned.
  • Add the template to provide the main reviewer with a checklist of things to do before (and after) merging.

smoia avatar Oct 14 '20 15:10 smoia

Codecov Report

Merging #316 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files           9        9           
  Lines         848      848           
=======================================
  Hits          804      804           
  Misses         44       44           

codecov[bot] avatar Oct 14 '20 16:10 codecov[bot]

Wow, I'm so excited for this! Let me know if there's anything I can do to help with this.

eurunuela avatar Oct 14 '20 18:10 eurunuela

This is a good idea! I will take a look at what you have so far, on Monday, and see if I have suggestions at this stage.

RayStick avatar Oct 16 '20 23:10 RayStick

This PR was marked as a work in progress a while ago. Should I look at it soon or wait?

RayStick avatar May 13 '21 14:05 RayStick

#315 was already merged, I think we can continue work on this PR.

eurunuela avatar May 14 '21 10:05 eurunuela

The main problem with this PR is that I didn't test it yet. If someone that has a bit of free time wants to try this out in a fake repository, please do so and help out finishing it!

smoia avatar May 14 '21 10:05 smoia

This PR might need updating, as well as more looking into how to make this work with our project board

smoia avatar Apr 18 '24 13:04 smoia