onelogin-aws-cli icon indicating copy to clipboard operation
onelogin-aws-cli copied to clipboard

[WIP] OTP push support

Open slycoder opened this issue 7 years ago • 2 comments

Support push for OL protect as an MFA. Note this is a work in progress. Due to some bugs in the OL api, this is not ready for prime time yet.

Description

For some devices, rather than entering in the code you should be able to respond to a push notification. This just requires changing the way verify factor is called a tiny bit.

Related Issue

#109

Motivation and Context

Responding to pushes to authorize is sometimes more ergonomic =).

How Has This Been Tested?

Not yet tested.

slycoder avatar Jun 05 '18 19:06 slycoder

Also thanks to @danmerl for getting the ball rolling on this PR.

slycoder avatar Jun 05 '18 19:06 slycoder

Codecov Report

Merging #122 into master will decrease coverage by 1.95%. The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #122      +/-   ##
=========================================
- Coverage   78.35%   76.4%   -1.96%     
=========================================
  Files           6       6              
  Lines         328     339      +11     
=========================================
+ Hits          257     259       +2     
- Misses         71      80       +9
Impacted Files Coverage Δ
onelogin_aws_cli/__init__.py 66.05% <30.76%> (-5.38%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74aab3b...c05aea3. Read the comment docs.

codecov-io avatar Jun 05 '18 19:06 codecov-io