Philipp Wolfer

Results 252 comments of Philipp Wolfer

First off: I like the general idea of allowing the user to select a different result if multiple matches are found. But the current implementation as it is now is...

> I would personally like to see the similarity score as the first column - but this is only a personal preference. I have really no strong opinion here. But...

> So let's just make a preliminary PR, that moves common code you need in your new classes to separate classes you'll inherit from. Yes, agreed on this

@RaysDev sorry for the lack of feedback fr our side. But yes, in general I still would like to see this finished. I am not available 5his weekend, but I...

So we are finally getting somewhere with the related stories merged :) @RaysDev Could you rebase this branch against current devel?

@RaysDev Sorry for the delay, but I also want to have this move forward. Last weeks have been rather busy on my side, though. With your other changes merged this...

Just detected the filters, those are pretty cool. Just a few notes: - The layout looks a bit cramped, should have at least some padding around - Right clicking the...

> I cloned your repo and made changes to the branch you mention above. I don't have permission to commit there. Is there something you need to grant? I thought...

My only concern is that I had thought after our recent discussion that we might get completely rid of the dateutil dependency. Is there any concrete use case for this...

Sorry for the long silence, I had been totally occupied by life here. Things look good to me. I can theoretically test the CD lookup feature, but right now don't...