passenger-nodejs-websocket-demo icon indicating copy to clipboard operation
passenger-nodejs-websocket-demo copied to clipboard

Add Vagrant

Open knpwrs opened this issue 10 years ago • 2 comments

This adds a Vagrant box which runs the demo on Nginx. If this sounds like a good idea I can go ahead and configure additional boxes for Apache and Standalone.

knpwrs avatar Oct 20 '15 14:10 knpwrs

Yes this is a good idea. A few comments though:

  • I think Vagrant-specific resource files, like the Nginx config file, should be placed in a directory named dev or vagrant in order to signal that they're only supposed to be used during development, not production.
  • The provisioning shell script should be stored in an external file so that syntax highlighting works properly.
  • The provisioning shell script should be idempotent. It looks like a reprovision would fail on the ln calls.

FooBarWidget avatar Oct 20 '15 14:10 FooBarWidget

Cool, I'll take a look at those things when I get home today.

knpwrs avatar Oct 20 '15 14:10 knpwrs