juvia icon indicating copy to clipboard operation
juvia copied to clipboard
verified publisher icon phusion

bug fixes (#12), Gemfile grouping, subdir feature (#13) and css cleanup

Open stbuehler opened this issue 12 years ago • 6 comments

  • Update cancan, fixing Comment.accessible_by (fixes #12)
  • Group database adaptors mysql/postgresql/sqlite
  • fix path handling for subdir mounting (fixes #13)
  • css fixes: typo, duplicates, pre/code should be visible in preview too, remove font for comments
    • the comments should use the same font as the page they are embedded in

stbuehler avatar Aug 17 '13 13:08 stbuehler

Sorry for taking so long to reply. Does this pull request obsolete issue #13?

FooBarWidget avatar Aug 21 '13 12:08 FooBarWidget

I've commited 2cf73f1 and 4c0641f for now.

FooBarWidget avatar Aug 21 '13 12:08 FooBarWidget

Yes, the commit with (fixes #13) should implement the feature requested in #13 :)

stbuehler avatar Aug 21 '13 14:08 stbuehler

It looks like I don't have enough time to get this merged in the short term. I'm preparing a conference trip and I'll be away for a week. I'll have a better look when I'm back.

FooBarWidget avatar Aug 23 '13 09:08 FooBarWidget

Back to work? http://youtu.be/YaQYrVQDPHE?t=6s :)

stbuehler avatar Sep 28 '13 19:09 stbuehler

I removed the hack to auto-detect the subdir mount; as i was migration juvia to rails 4 the hack broke, and the internal handling got way too complicated to workaround it again.

This also means that I didn't test it; my previous tests were done on my main juvia instance which was mounted at different urls, but now is only mounted at '/' (you can configure only one static subdir).

stbuehler avatar Dec 16 '13 16:12 stbuehler