digest-sha3-ruby
digest-sha3-ruby copied to clipboard
Fix 'format not a string literal and no format arguments [-Werror=format-security]'
I'd like to add a simple fix. The problem is that at least in Ubuntu gcc has "-Wformat-security" as a default flag, and together with "-Werror=format-security" they lead to an error if fprintf is used without format string (https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wformat_-Wformat-security). The issue is #7
Would love to see it merged (would fix bug in our gem - https://github.com/EthWorks/ethereum.rb/issues/11)
I'd also like to see this merged, it affects the ruby-eth gem as well.
plz merge
please! Thank you!
This gem is abandoned. Try to use: https://github.com/izetex/digest-sha3-ruby (add to Gemfile: git "https://github.com/izetex/digest-sha3-ruby" do gem 'digest-sha3' end )
an easy workaround would be
bundle config build.digest-sha3 --with-cflags="-Wno-format-security"
why not merging this?
@mathieujobin I'm not sure why
@FooBarWidget could you please take a look at this PR and provide feedback?
Any update on this? This rolls into this new issue if the repo is going to be maintained: https://github.com/phusion/digest-sha3-ruby/issues/13
@FooBarWidget
Thank you for the fix.
I published this as keccak
https://github.com/q9f/keccak.rb
I published this as
keccak
https://github.com/q9f/keccak.rb
Thanks