digest-sha3-ruby icon indicating copy to clipboard operation
digest-sha3-ruby copied to clipboard

Fix 'format not a string literal and no format arguments [-Werror=format-security]'

Open Eugenpaul opened this issue 7 years ago • 12 comments

I'd like to add a simple fix. The problem is that at least in Ubuntu gcc has "-Wformat-security" as a default flag, and together with "-Werror=format-security" they lead to an error if fprintf is used without format string (https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wformat_-Wformat-security). The issue is #7

Eugenpaul avatar Jul 21 '17 16:07 Eugenpaul

Would love to see it merged (would fix bug in our gem - https://github.com/EthWorks/ethereum.rb/issues/11)

marekkirejczyk avatar Jul 23 '17 08:07 marekkirejczyk

I'd also like to see this merged, it affects the ruby-eth gem as well.

se3000 avatar Oct 12 '17 16:10 se3000

plz merge

hswick avatar Feb 06 '18 08:02 hswick

please! Thank you!

mtomov avatar Feb 20 '18 09:02 mtomov

This gem is abandoned. Try to use: https://github.com/izetex/digest-sha3-ruby (add to Gemfile: git "https://github.com/izetex/digest-sha3-ruby" do gem 'digest-sha3' end )

d00rsfan avatar Jul 28 '18 11:07 d00rsfan

an easy workaround would be

bundle config build.digest-sha3 --with-cflags="-Wno-format-security"

hardywu avatar Jan 06 '19 02:01 hardywu

why not merging this?

mathieujobin avatar Jul 05 '19 11:07 mathieujobin

@mathieujobin I'm not sure why

@FooBarWidget could you please take a look at this PR and provide feedback?

cdesch avatar Aug 05 '21 17:08 cdesch

Any update on this? This rolls into this new issue if the repo is going to be maintained: https://github.com/phusion/digest-sha3-ruby/issues/13

@FooBarWidget

cdesch avatar Aug 31 '21 15:08 cdesch

Thank you for the fix.

rafa977 avatar Nov 30 '21 09:11 rafa977

I published this as keccak https://github.com/q9f/keccak.rb

q9f avatar Nov 30 '21 13:11 q9f

I published this as keccak https://github.com/q9f/keccak.rb

Thanks

elissonmichael avatar Oct 20 '22 15:10 elissonmichael