phunkyfish

Results 332 comments of phunkyfish

Without the details of the addons you have installed and said versions it could be difficult to reproduce, hence the ask to always provide a log.

@fuzzard do you remember where we make the changes for binary addons?

> @phunkyfish It should be set from [`Toolchain_binaddons.cmake`](https://github.com/xbmc/xbmc/blob/master/tools/depends/target/Toolchain_binaddons.cmake.in#L84) which uses `platform_cxxflags`. I guess we do need to set `set(CMAKE_CXX_STANDARD 20)` now to force c++20 in binary addons. Once all the...

> Building with C++20 causes this crash (also crashes in non sanitized build): > > ``` > AddressSanitizer:DEADLYSIGNAL > ================================================================= > ==102770==ERROR: AddressSanitizer: SEGV on unknown address 0x5a73e6eed620 (pc 0x7a0a0515c374...

> > > @phunkyfish It should be set from [`Toolchain_binaddons.cmake`](https://github.com/xbmc/xbmc/blob/master/tools/depends/target/Toolchain_binaddons.cmake.in#L84) which uses `platform_cxxflags`. I guess we do need to set `set(CMAKE_CXX_STANDARD 20)` now to force c++20 in binary addons. >...

Looks like StrungUtils fails on OSX: ``` 07:09:23 /Users/Shared/jenkins/workspace/OSX-64/build/build/build-p8-platform/src/build-p8-platform/src/util/StringUtils.cpp:469:49: error: expected expression 07:09:23 str.erase(::find_if(str.rbegin(), str.rend(), [](char s) { return isspace_c(s) == 0; }).base(), str.end()); ``` what is the change in...

We’ll need someone to bisect this to find the problem commit. Which means someone who can both build kodi on windows and run the media portal addon. having not used...

Bisecting, can mean a lot of builds. But would be next to impossible to do this without being able to build for windows. Let’s see can we solve the build...

Let’s solve for the addon not building correctly for omega first. Once we have that and if there is still a problem we try the bisecting path.