rebook icon indicating copy to clipboard operation
rebook copied to clipboard

Published 20 hours ago • verified publisher icon phulin

It seems this 0.01 should be 1.01? I guess.

Open jimlinntu opened this issue 4 years ago • 1 comments

https://github.com/phulin/rebook/blob/177daa7c5fe20354888ebc76b300e87f3adcb918/newton.pyx#L78

Hi, I just found that in this line, you use u_minus and u_plus, so I guess t should be 0.99 * t and 1.01 * t (rather than 0.01)?

jimlinntu avatar Jun 30 '20 06:06 jimlinntu

Oh, I guess you are trying to find the closest root t to the origin. So if s(0.99 * t) * s(0.01 * t) < 0, there must be a solution closer to the camera(the origin). Am I correct?

jimlinntu avatar Jun 30 '20 06:06 jimlinntu