Fix HTML output for title rows

[michaelsippel]

As described in #159 , .print_html() produced wrong html for title-rows.

This PR fixes this issue by introducing a boolean title flag in Cell::print_html / Row::print_html to select the appropriate tag (td or th).

[pinkforest]

I would not like to break the API and the API would be confusing that adds thinking overhead when it could be automatic.

Feel like there should be internal state that tracks whether it is the first row and then use that as implementation detail ?

[michaelsippel]

Thanks for the feedback @pinkforest ! You are right, I didn't really consider Cell::print_html() to be part of the API since usually you would call Table::print_html() instead of directly calling Row::print_html() or Cell::print_html() most of the time. There, no additional thinking overhead would be added, since titles are added via Table::set_titles(), which sets the separate titles member of Table. From there the information whether the cell is a title-cell or not is passed onto Row::print_html() and Cell::print_html() , where this information was not available before.

Deciding the cell type should not be based upon the order, since it is already given by the table as a separate row.

To eliminate the API-change in Row and Cell, I prepared a new patch which adds cell_type to each cell indicating whether the cell is a title-cell (CellType::Head) or a data-cell, which is the default (CellType::Data). Now, all print_html() function signatures remain intact and Cell simply uses its cell_type to decide between outputting <th> or <td>. The cell-type for all cells in the title-row is then automatically set by Table::set_titles().