Philipp Schaad

Results 30 comments of Philipp Schaad

Hi, thank you for creating the issue! What version of Python are you using?

@luca-patrignani It looks like (since the Loop Regions PR was merged into master) this branch will need to be re-based on top of current master to avoid the conflicts. If...

Any thoughts on how to go about the pyFV3 tests? It appears that this mostly comes down to GT4Py cartesian, which of course is not adapted to use the new...

Now that 1.0 is released it is time to revisit this. I would be in favor of merging this ASAP due to the humongous change, which makes divergence a real...

@tbennun The only tests that are failing are expected to fail (FV3): > Note: The FV3 integration test fails and will continue to fail with this PR, since GT4Py cartesian,...

This is very hard to debug, but I did some investigating. I suspect the error observed in the pipeline is a delayed symptom of one (or more likely, many) earlier...

@FlorianDeconinck tagging you so you are aware of this discussion and can chime in :-)

> My only ask would be to retain some future-Phillipp time so we can have support in moving to the Control Flow Regions Absolutely, I am happy to help in...

Apart from @acalotoiu 's comment, this looks good to me. However, I want to add: I believe that the presence of more and more niche transformations like this should make...

Thank you for addressing the comments @pratyai! In general, this looks good to me. However, I would prefer if this PR could be part of a brief discussion in the...