membrane

membrane copied to clipboard

check to see if other backends support testing

1

phronmophobic

Improve testing support for `membrane.webgl` backend.

2

Loading the `membrane.webgl` namespace will throw an exception if some of the browser APIs are missing. This makes it annoying for writing/running tests outside of the browser environment. Also, on...

phronmophobic

Update Skija backend to allow multiple windows without crashing

3

phronmophobic

You can currently have recursive defui component calls, but it may require repeating the signature for the proper metadata to exist. Duplicating the component signature shouldn't be required to use...

phronmophobic

Update tutorial

2

rgkirch

set initial window location to arg or default to 0

8

Idk if initial windows have a non-zero default location. If so, then this overrides the default behavior which may be undesirable.

rgkirch

redundant terminal example?

1

It's a little confusing that there are two examples https://github.com/phronmophobic/membrane/blob/master/src/membrane/example/terminal_todo.clj https://github.com/phronmophobic/terminal-todo-mvc/blob/master/src/terminal_todo_mvc/core.clj I'm just trying to be helpful by pointing this out. It's not really an issue. It came up for...

rgkirch

cljdoc fails

1

https://cljdoc.org/builds/55459 ``` "Could not locate spec_provider/provider__init.class, spec_provider/provider.clj or spec_provider/provider.cljc on classpath. Please check that namespaces with dashes use underscores in the Clojure file name."}} ```

rgkirch

https://github.com/phronmophobic/membrane/blob/master/src/membrane/java2d.clj#L258 https://github.com/phronmophobic/membrane/blob/master/src/membrane/java2d.clj#L290 Maybe use one to implement the other? Like [this](https://github.com/phronmophobic/membrane/blob/master/src/membrane/java2d.clj#L298)

rgkirch

Use more accurate metrics when rendering text in java2d

3

Currently, `.getHeight` from FontMetrics is used for line height (see [here](https://github.com/phronmophobic/membrane/blob/e547cdcec33239b3920428a47b9966b93d300be8/src/membrane/java2d.clj#L271)), but `.getHeight` returns an integer which is subtly wrong. Instead, the line height should be calculated using [LineMetrics](https://docs.oracle.com/javase/7/docs/api/java/awt/font/LineMetrics.html) (see...

phronmophobic