Results 110 comments of Adrian

Yea, I agree. On the one hand, we could just execute the script as like a shell script using something like `-c`, but that would break use cases like opening...

This is something I intend to do at some point, but I feel like I only recently got all my projects using the clojure cli, and now it's all deprecated...

I've been using github actions, so I do prefer github actions over Circle CI.

The wrapper looks pretty straightforward. I'll check it out! Also, the main issue is that git url is wrong in the pom.xml, right?

I started a branch to fix the pom if that's one of the main issues, https://github.com/phronmophobic/membrane.term/pull/35. I am still interested in implementing some of the other suggestions you have. It...

> @phronmophobic, previously the hardcoded launch command was ["/bin/bash" "-l"]. > The new default loses the -l arg, do we need to retain it? To be honest, I'm not sure....

Here's some interesting info in kitty: https://github.com/kovidgoyal/kitty/blob/c8c6f8691f4aa84f4d798428af268319b898798f/kitty/child.py#L257

More references: https://github.com/alacritty/alacritty/issues/645 https://github.com/kovidgoyal/kitty/issues/247 As far as I can tell, it seems like passing `--login` is the way to go.

> They seem to be macOS related? > Does Linux also need the --login arg? I've read these tickets a few times now and I'm still not 100% sure. It...

> So maybe the 2 techniques are equivalent? That's what I was thinking as well. The reason I think we should prefer using the "-" prefix over the `--login` arg...