silverstripe-jsontext icon indicating copy to clipboard operation
silverstripe-jsontext copied to clipboard

Loosen constraints for ss3 projects

Open bumbus opened this issue 6 years ago • 3 comments

Hi there, may i ask if you could loosen the php constraints ( at the moment >=5.4,<7), so it is possible to run silverstripe 3 projects in php7.

https://github.com/phptek/silverstripe-jsontext/blob/00594a21046d7cd5937d4830a916b396ae2c3bba/composer.json#L15

I gave it a test with (php 7.0.27) https://github.com/arillo/silverstripe-jsontext/tree/dev and it did work.

bumbus avatar Apr 25 '18 10:04 bumbus

@bumbus Thanks for this. I have created a new 3-series integration branch "3.x" and patched it as per your request. Can you please check this branch out, and run the unit-test suite across it in PHP7.0.27? :-)

phptek avatar Apr 29 '18 09:04 phptek

@phptek thank you for looking into this. I gave it a test run. Basically it looks ok, but somehow there seem to be some problems with the way the tests are written:

$ sake dev/tests/module/jsontext/
ALL TESTS
Running test cases:
--------------------
jsontextbasictest, jsontextextensiontest, jsontextintegrationtest, jsontextquerytest,
jsontextsetvaluetest, jsontexttest

..E
JSONTextBasicTest::testLast
Argument #1 of PHPUnit_Framework_Assert::assertInstanceOf() must be a class or interface name
PHPUnit_Framework_Assert::assertInstanceOf(Float,33.3333)
JSONTextBasicTest.php:116

--------------------
.F
JSONTextExtensionTest::testExceptionThrownOnBeforeWrite
Failed asserting that exception of type "\JSONText\Exceptions\JSONTextException" is thrown.
--------------------
..E
JSONTextQueryTest::testQueryWithMatchOnInt
Argument #1 of PHPUnit_Framework_Assert::assertInstanceOf() must be a class or interface name
PHPUnit_Framework_Assert::assertInstanceOf(Float,44.6)
JSONTextQueryTest.php:83

--------------------
E
JSONTextQueryTest::testQueryWithMatchOnStr
Argument #1 of PHPUnit_Framework_Assert::assertInstanceOf() must be a class or interface name
PHPUnit_Framework_Assert::assertInstanceOf(Float,99.99)
JSONTextQueryTest.php:184

--------------------
E
JSONTextQueryTest::testQueryWithMatchOnPath
Argument #1 of PHPUnit_Framework_Assert::assertInstanceOf() must be a class or interface name
PHPUnit_Framework_Assert::assertInstanceOf(Float,99.99)
JSONTextQueryTest.php:311

--------------------
.......E
JSONTextTest::testToSSTypes
Argument #1 of PHPUnit_Framework_Assert::assertInstanceOf() must be a class or interface name
PHPUnit_Framework_Assert::assertInstanceOf(Float,33.3333)
JSONTextTest.php:103

--------------------


 AT LEAST ONE FAILURE

18 tests run: 12 passes, 6 failures, and 0 incomplete
Maximum memory usage: 54.0M

bumbus avatar Apr 30 '18 13:04 bumbus

Weird. Which version of phpunit are you using?

phptek avatar May 01 '18 00:05 phptek