phpstan-strict-rules issues

Detect variable reuse with different type

6

# Feature request I think this is okay. ```php $var = 'apple'; $var = 'nice ' . $var; ``` But many developers tend to stuff other type into the same...

szepeviktor

FR: report overriding outer scope var in `catch` statement

```php private static function printExceptionMessage(\Throwable $e) : string{ $errstr = preg_replace('/\s+/', ' ', trim($e->getMessage())); $errno = $e->getCode(); try{ $errno = ErrorTypeToStringMap::get($errno); }catch(\InvalidArgumentException $e){ //pass } $errfile = Filesystem::cleanPath($e->getFile()); $errline =...

dktapps

Feature request: report useless continue statement

2

Hi, the following code doesn't report any warning, but the `continue` statement is useless: ```php $foo = [1, 2, 3]; $bar = [$foo]; foreach ($bar as $var) { foreach ($var...

Slamdunk

Provide additional context in the DisallowedEmptyRule error message

4

In [doctrine/dbal](https://github.com/doctrine/dbal), the Schema and Driver APIs use `array` parameters heavily (e.g. as connection parameters and column definitions). While overall the value type is mixed, each array element usually has...

morozov

Proposal: Forbidding constant "overriding"

4

Const overrides violate const invariants and are not LSP-compliant (types can be changed randomly). There may be dragons when constants are used with `static::` (sniff request to forbid that: https://github.com/slevomat/coding-standard/issues/473)...

Majkl578

Closure: report missing function parameter typehint and missing return type

2

Hi, I would like to enable for Closures the two rules already present for normal functions, `MissingFunctionParameterTypehintRule` and `MissingFunctionReturnTypehintRule`. I found that master branch has this commit https://github.com/phpstan/phpstan-strict-rules/commit/491540d3bfa11e218cdba868c4128891ba63b72f which already...

Slamdunk