phpstan-strict-rules icon indicating copy to clipboard operation
phpstan-strict-rules copied to clipboard

Disallow offset access on string

Open mvorisek opened this issue 1 year ago • 0 comments

I propose to add, to strict rules, a rule to reject string offset access like:

$str[$index];
$str[5];

in favor of

substring($str, $index, 1)
substring($str, 5, 1)

The main motivation is to detect wrongly declared types. Currently when $var is declared wrongly as string instead of string[], it is undetected.

mvorisek avatar Jun 29 '23 09:06 mvorisek