phpstan-src

phpstan-src copied to clipboard

Don't report "is always true/false" for conditionally defined variables

2

closes https://github.com/phpstan/phpstan/issues/6830

staabm

Mark DOMNamedNodeMap as taking a covariant DOMNode

18

And indicate that `DOMNode::$attributes` is a node map of `DOMAttr`. Not sure how to write a test, nor if this is where I need to amend the stubs. But happy...

Girgias

Fixes https://github.com/phpstan/phpstan/issues/12250 I made a bug report https://github.com/phpstan/phpstan/issues/12250, and this PR is fixing that. While all the current tests are passing this PR adds a conditional assignment to NewAssignedToPropertyVisitor which...

netpok

This is very W.I.P. and I think this is the correct way to fix it, but I don't know if I should update `Type::isOffsetAccessible()` to pass in the `$mode` parameter...

Girgias

https://www.php.net/manual/en/function.imagecreatefromavif.php https://www.php.net/manual/en/function.imagecreatefromtga.php https://www.php.net/manual/en/function.odbc-procedurecolumns.php https://www.php.net/manual/en/function.odbc-procedures.php https://www.php.net/manual/en/function.openssl-cipher-key-length.php https://www.php.net/manual/en/function.pg-lo-import.php https://www.php.net/manual/en/function.sodium-crypto-aead-aegis128l-decrypt.php https://www.php.net/manual/en/function.sodium-crypto-aead-aegis256-decrypt.php https://www.php.net/manual/en/function.ssh2-forward-accept.php https://www.php.net/manual/en/function.ssh2-forward-listen.php

icanhazstring

Allow gitlab ci to be detected

1

Gitlab CI wasn't being detected by the `CiDetectedErrorFormatter`. This MR allows detection so that the `CiDetectedErrorFormatter` can be used for gitlab as well.

BackEndTea

Change return type of apcu_inc & apcu_dec function

3

See https://www.php.net/manual/en/function.apcu-inc.php

LordSimal

Refactor ComposerPhpVersionFactory

1

extracts `ComposerPhpVersionParser` to allow re-use of version-string into min/max `PhpVersion` parsing. I think this will be usefull in https://github.com/phpstan/phpstan-phpunit/pull/269 to build `PhpVersion` min/max for versions in PHPUnits `#[RequiresPhp('5.*')]`-attribute.

staabm

FNSR ExpressionResultStorage

2

ondrejmirtes

Fix get_object_vars() return type

1

I created new pull request for: https://github.com/phpstan/phpstan-src/pull/4580 because i can not update source branch.

Triplkrypl