phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard
verified publisher icon phpstan

do not skip Generator for MissingTypehintCheck

Open Flyingmana opened this issue 5 months ago • 6 comments

references #7498

only a draft for now, I want to see which test are all failing and for what reasons.

Flyingmana avatar Aug 05 '25 23:08 Flyingmana

Explained the wanted changes here https://github.com/phpstan/phpstan/issues/7498#issuecomment-3239381890

ondrejmirtes avatar Aug 30 '25 16:08 ondrejmirtes

I would love to this moving forward. Are you still interested in your PR @Flyingmana ?

I think you just need to

  • Rebase/Fix conflicts
  • Describe the iterable type in some stubs/tests

VincentLanglet avatar Sep 14 '25 10:09 VincentLanglet

Yes, might have time for it later today, but latest next weekend

Flyingmana avatar Sep 14 '25 10:09 Flyingmana

I think now all is fixed which belongs to this repository, the rest is separate repositories

Flyingmana avatar Sep 14 '25 23:09 Flyingmana

This pull request has been marked as ready for review.

phpstan-bot avatar Sep 14 '25 23:09 phpstan-bot

I'd like to see more tests with the other no-longer-skipped types like Generator.

I added new tests/examples for generics in tests/PHPStan/Rules/Functions/data/missing-function-return-typehint.php

Flyingmana avatar Nov 23 '25 13:11 Flyingmana