phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard
verified publisher icon phpstan

Improve StrSplit returnType

Open VincentLanglet opened this issue 7 months ago • 2 comments

Hi @herndlm

I saw you worked multiple times on this extension with

  • https://github.com/phpstan/phpstan-src/pull/1496
  • https://github.com/phpstan/phpstan-src/pull/1544

So you might want to review this.

I still need to update the LegacyNodeScopeResolverTest.

@ondrejmirtes Do you want me to fix the LegacyNodeScopeResolverTest as if, or would it be ok to migrate them inside the new NodeScopeResolverTest instead ?

VincentLanglet avatar May 18 '25 19:05 VincentLanglet

If it's ok, I opened https://github.com/phpstan/phpstan-src/pull/4000 first

VincentLanglet avatar May 18 '25 21:05 VincentLanglet

This pull request has been marked as ready for review.

phpstan-bot avatar Jun 13 '25 00:06 phpstan-bot

@ondrejmirtes The HasPropertyTypeTest::testIsSuperTypeOf with data set #4 seems random, On this PR it fails on PHP 8.4 ubuntu, But on another PR it onl fails on PHP 8.3 ubuntu https://github.com/phpstan/phpstan-src/actions/runs/16353254353/job/46205186388?pr=3906 And it changes sometimes when I repush.

So I don't think, it's related to the PR ; this is now ready.

VincentLanglet avatar Jul 17 '25 18:07 VincentLanglet

Thank you!

ondrejmirtes avatar Jul 21 '25 12:07 ondrejmirtes