phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard
verified publisher icon phpstan

Fix empty regex and empty alternation parse

Open mvorisek opened this issue 1 year ago • 3 comments

fix https://github.com/phpstan/phpstan/issues/11762

mvorisek avatar Sep 27 '24 12:09 mvorisek

This pull request has been marked as ready for review.

phpstan-bot avatar Sep 27 '24 22:09 phpstan-bot

Do empty alternations or empty capturing groups have real world relevance?

I don't think I have ever seen a regex using it..?

staabm avatar Sep 29 '24 10:09 staabm

They definitely do, ~@(|phpstan-)param~ is a small example.

mvorisek avatar Sep 29 '24 10:09 mvorisek

This pull request has been marked as ready for review.

phpstan-bot avatar Feb 04 '25 23:02 phpstan-bot

Looks fine, thank you.

ondrejmirtes avatar Feb 11 '25 16:02 ondrejmirtes

Thank you ❤

mvorisek avatar Feb 11 '25 20:02 mvorisek