phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard

Update `Locale` signatures

Open devnix opened this issue 1 year ago • 4 comments

I'm not sure about documenting all optional parameters of Locale::composeLocale() as it has no effect when introducing non-documented parameters to the function, but I've reviewed all the functions, even the undocumented ones and AFAIK these are the correct signatures 😊

devnix avatar Jan 18 '24 09:01 devnix

Not sure why this is failing: https://github.com/phpstan/phpstan-src/actions/runs/7568063545/job/20608638825?pr=2880

devnix avatar Jan 22 '24 15:01 devnix

That build failure is not the fault of this PR.

ondrejmirtes avatar Jan 22 '24 19:01 ondrejmirtes

Also please get rid of the merge commit, the history should be linear (use rebase instead).

ondrejmirtes avatar Jan 22 '24 19:01 ondrejmirtes

I think this should do it 😄

devnix avatar Jan 28 '24 22:01 devnix

Thank you.

ondrejmirtes avatar May 30 '24 13:05 ondrejmirtes

Did this fix https://github.com/phpstan/phpstan/issues/7855 ?

lazka avatar May 30 '24 14:05 lazka