Performance improvements

Open rvanvelzen opened this issue 3 years ago • 2 comments

Some perf improvements (mostly related to constant arrays) implemented while investigating phpstan/phpstan#8146.

Oct 13 '22 12:10 rvanvelzen

with the many type related cleanups I do on 1.9.x we need to be careful to not cause conflicts if bigger type changes are made on 1.8.x still :)

Oct 13 '22 13:10 herndlm

I can just point this at 1.9.x of course, though the merge looked relatively clean locally :)

Oct 13 '22 14:10 rvanvelzen

I rebased this, but the performance issue in the new test doesn't go away :/

Dec 10 '22 22:12 ondrejmirtes

This is probably a dead end :) We already optimized 8146, mainly by dumbing down the arrays again, and be a bit more forgiving with oversized arrays in type checking.

Jan 16 '23 21:01 ondrejmirtes