phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard

Fix #7531 - "Unreachable statement" false positive for html whitespace

Open murilohpucci opened this issue 2 years ago • 4 comments

Hey, first time here, I hope this can help you.

Fixing: #7531

murilohpucci avatar Jul 06 '22 21:07 murilohpucci

You should add a test with non-whitespace html as well, to make sure that that is reported.

rvanvelzen avatar Jul 07 '22 16:07 rvanvelzen

You should add a test with non-whitespace html as well, to make sure that that is reported.

I hope I got it right, I've just added one more test scenario where there's non-whitespaces, and in this case it's expected to not be reported by phpstan

murilohpucci avatar Jul 07 '22 17:07 murilohpucci

Sorry, I guess that was a bit ambiguous. I avtually meant non-whitespace and non-empty, because that should be reported :)

rvanvelzen avatar Jul 07 '22 17:07 rvanvelzen

@murilohpucci Would be nice if you were able to finish this PR :)

ondrejmirtes avatar Sep 01 '22 21:09 ondrejmirtes