phpstan-nette

phpstan-nette copied to clipboard

Update ComponentModel\Container stub for component-model 3.1.0

5

That version changes the return type to array when `$deep` argument is `false` (default): https://github.com/nette/component-model/commit/7f613eed7f5e57b6bde2d0be1bfdbb7e161620b3 It also deprecates the arguments but we cannot add deprecated annotation to those. https://github.com/nette/component-model/commit/4e0946a788b4ac42ea903b761c693ec7dd083a69

jtojnar

Container::getComponents() returns incorrect type

3

component-model 3.1.0 returns array `Container::getComponents()` when `$deep === false`: https://github.com/nette/component-model/commit/7f613eed7f5e57b6bde2d0be1bfdbb7e161620b3 instead of `Iterator`: https://github.com/phpstan/phpstan-nette/blob/8af94743efcc6d1e685f2ffd7ab279e39c96429c/stubs/ComponentModel/Container.stub#L11-L13 The return type should be something like ```php @phpstan-return ( $deep is true ? ($filterType is...

jtojnar

Mirroring the upstream change from 3.1.10: https://github.com/nette/forms/commit/fb2df3bfabf5f7ec11f622f8940d1e6e4d39582e The new method also makes the `returnType` argument optional, defaulting to `ArrayHash`. Also add handling of `returnType` taking `class-string`. Finally, add tests based...

jtojnar