Add missing descriptors for `SmallFloatType` and `EnumType`
- https://github.com/doctrine/dbal/pull/6536 (since dbal 4.2)
- https://github.com/doctrine/dbal/pull/6471 (since dbal 4.1)
- Resolves #619
tests describing what this actually fixes would be nice
It is pretty painful to test new doctrine here (due to all the compatibility hacks). But added.
Would it be possible to read the options ?
Yes, implemented.
Would it be possible to read the options ?
Yes, implemented.
Great.
Could add a test for the EntityColumnRule too https://github.com/phpstan/phpstan-doctrine/blob/a1a9efb64708580a9d8b0d150340f7777d2b8aa0/tests/Rules/Doctrine/ORM/EntityColumnRuleTest.php#L35
(I assume we just need to add an enum field in the BrokenEntity https://github.com/phpstan/phpstan-doctrine/blob/a1a9efb64708580a9d8b0d150340f7777d2b8aa0/tests/Rules/Doctrine/ORM/data/MyBrokenEntity.php)
I assume that
/**
* @Column(type="enum", options={"values"={"a", "b", "c"}})
* @var 'a'|'b'|'c'
*
public $enum;
shouldn't be reported but
/**
* @Column(type="enum", options={"values"={"a", "b", "c"}})
* @var string
*
public $enumWithUnprecisedPHPDoc;
should be reported
Thank you.