Issues with "type_scope_conventions"

[adaniloff]

Q	A
Version	GrumPHP 0.15.2
Bug?	yes
New feature?	no
Question?	no
Documentation?	yes

Hi there, 2 issues:

1. Documentation issues about type_scope_conventions

type_scope_conventions:
  - types:
    - build
    - ci
    - chore
    - docs
    - feat
    - fix
    - perf
    - refactor
    - revert
    - style
    - test
  - scopes: []

should be (both for type and scope i doc btw):

type_scope_conventions:
  types:
    - build
    - ci
    - chore
    - docs
    - feat
    - fix
    - perf
    - refactor
    - revert
    - style
    - test
  scopes: []

Otherwise the conf is not loaded.

2. enforce_capitalized_subject does not work well with type_scope_conventions defined:

• "fix: Some capitalized subject" ----------> fails (but should not)
• "Fix: some uncapitalized subject" ------> succeed (but should fail)

[veewee]

The first issue has been handled in more recent versions. You don't need both keys set anymore. The second issue is harder. The type scope convention part is detached from the check that validates that the subject has a capital. I don't think that will be something we can fix easily without rethinking how the task works internally.

Feel free to provide a PR.

[adaniloff]

Yeah I had a little look so I understand why is it harder to resolve :) If I got some time at any point, I'll try.

Thanks for your reply, have a good day :)