phpro
Invoke GrumPHP executable using the PHP binary so it respects the PHP version Composer was invoked with.
| Q | A |
|---|---|
| Branch | invoke-grumphp-using-php-binary |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Documented? | no |
| Fixed tickets | - |
Fixes #1170
@echernyavskiy Thanks for the PR. This doesn't seem to be working on windows. Can you take a look at the failing appveyor tasks?
@veewee, the 8.4 failures there look like they have to do with the environment:
php --version
php : PHP Warning: 'C:\windows\SYSTEM32\VCRUNTIME140.dll' 14.22 is not compatible with this PHP build linked with 14.43 in Unknown on line 0
For other PHP versions it looks like GrumPHP's pre-commit file is not getting created for some reason. I'm not sure how to investigate this - if someone running Windows is able to look into it, that'd be great.
I don't own a Windows computer either. But can't merge this the way it is, since it breaks every windows installation :) Previously, i've used appveyor to debug this kind of stuff directly from within the E2E tests and rerun. It's slow and tyring, but it gets the job done.