grumphp icon indicating copy to clipboard operation
grumphp copied to clipboard

There was a double loading of the autoloader

Open dezer32 opened this issue 1 year ago • 2 comments

Q A
Branch master for features and deprecations
Bug fix? yes/no
New feature? yes/no
BC breaks? yes/no
Deprecations? yes/no
Documented? yes/no
Fixed tickets comma-separated list of tickets fixed by the PR, if any

New Task Checklist:

  • [ ] Are the dependencies added to the composer.json suggestions?
  • [ ] Is the doc/tasks.md file updated?
  • [ ] Are the task parameters documented?
  • [ ] Is the task registered in the tasks.yml file?
  • [ ] Does the task contains phpunit tests?
  • [ ] Is the configuration having logical allowed types?
  • [ ] Does the task run in the correct context?
  • [ ] Is the run() method readable?
  • [ ] Is the run() method using the configuration correctly?
  • [ ] Are all CI services returning green?

dezer32 avatar Aug 27 '24 14:08 dezer32

Thanks for the PR.

Can you give me more details about what is going wrong exactly. I'm not sure if adding an env var for this purpose is the way to go. Maybe there are better solutions?

veewee avatar Aug 30 '24 06:08 veewee

“Hi, sorry for the lack of information :)” “GrumPHP is connected in the project, and the project runs locally through Docker using Docker-sync. An error occurs stating that the Composer autoload class is already included. I found out that this place includes the class, and since GrumPHP is installed only in the project and nowhere else, it tries to include it a second time in the loop below.”

dezer32 avatar Sep 02 '24 12:09 dezer32

I don't fully grasp the issue nor the implementation. I don't think it's a good idea to use an env variable to decide what to load or not.

Therefore, I will be closing this PR. Feel free to provide additional information, a reproducer, ... if you want to continue on this. Thanks anyway!

veewee avatar Nov 26 '24 12:11 veewee