php-code-generator icon indicating copy to clipboard operation
php-code-generator copied to clipboard

Published 20 hours ago • verified publisher icon phpowermove

Using nikic/php-parser version 4 cause errors

Open edmondscommerce opened this issue 6 years ago • 3 comments

Using the v4 version of nikic/php-parser causes various errors when the code is run.

This is not showing up in the tests at the moment because the require-dev section needs sami which locks the version to 3. Removing this requirement will bring in the latest version and show the errors.

I've done this in a fork so the errors can be seen, the travis output is here https://travis-ci.org/edmondscommerce/php-code-generator/jobs/422187128

edmondscommerce avatar Aug 29 '18 18:08 edmondscommerce

Welcome to dependency hell 👿

Thanks for making them visible. Any idea how to run tests against v4 of php-parser, while maintaining dep to sami?

gossi avatar Aug 30 '18 16:08 gossi

Just looked for alternatives of sami (since they stopped it). There is phpDox and apiGen. Switichting to either of them, I can drop the sami dependency and fully incorporate php-parser v4.

gossi avatar Nov 17 '18 18:11 gossi

Hey @edmondscommerce can you try with recent master? I dropped sami and everything else that prevented me from updating. I made php 7.2 as a minimum version, since 7.1 reach(ed) EOL. Can you try and see if it works for you?

gossi avatar Nov 24 '18 14:11 gossi