YiiSolr icon indicating copy to clipboard operation
YiiSolr copied to clipboard

ASolrSort method declaration in E_STRICT error mode

Open cjaegle opened this issue 12 years ago • 1 comments

I get the following error message when using a AsolrDataProvider in PHP E_STRICT error mode:

Declaration of ASolrSort::getOrderBy() should be compatible with that of CSort::getOrderBy()

I guess adding a parameter would fix this:

public function getOrderBy($criteria=null)
{
    throw new CException('Solr sorting does not support ORDER BY');
}

cjaegle avatar Aug 14 '12 09:08 cjaegle

Fixed on this commit.

denis-sanches avatar Nov 05 '18 17:11 denis-sanches