themes icon indicating copy to clipboard operation
themes copied to clipboard

New theme added for compatible with 5.x

Open khadkamhn opened this issue 4 years ago • 7 comments

Can you please review this theme?

khadkamhn avatar Mar 04 '21 17:03 khadkamhn

Hi @khadkamhn What license are the fonts/* files ?

williamdes avatar Mar 04 '21 22:03 williamdes

@williamdes

Please check the above url. https://github.com/feathericons/feather/blob/master/LICENSE

khadkamhn avatar Mar 05 '21 07:03 khadkamhn

@williamdes

Please check the above url. https://github.com/feathericons/feather/blob/master/LICENSE

Perfect, would you mind copying the license file in the folder please?

Also it would be nice to only have scss files and not compiled css files

cc @mauriciofauth

williamdes avatar Mar 05 '21 08:03 williamdes

@williamdes

I have added the LICENSE file of that font and the SCSS files already exist.

khadkamhn avatar Mar 07 '21 16:03 khadkamhn

How to upload a theme 5.2 in dark mode?

AppCarde avatar Mar 10 '22 14:03 AppCarde

@williamdes

I have added the LICENSE file of that font and the SCSS files already exist.

Thank you ! Wow near one year already past..

@mauriciofauth could you help with the review ?

williamdes avatar Apr 09 '22 13:04 williamdes

I just tried this theme and it needs some fixing to work on 5.1 and a bit more for 5.2 Apart from that it really looks good and cool ! The icons are very nice

williamdes avatar May 24 '22 14:05 williamdes

I am keeping this on hold until I review it. Thank you for the recent changes ! You can git reset --hard on your remote master branch, I force pushed it to clean up the history and fix this PR

williamdes avatar Dec 03 '22 13:12 williamdes

On 5.2 I found this bug

image

williamdes avatar Jan 01 '23 07:01 williamdes

I force pushed your branch and updated your css files, also updated bootstrap.scss You can hard reset onto the master branch and create a new branch for your fixes for 5.2 :)

williamdes avatar Jan 01 '23 07:01 williamdes