sql-parser icon indicating copy to clipboard operation
sql-parser copied to clipboard

Change error handling from throwing an exception to returning a boolean value

Open annexus254 opened this issue 3 years ago • 1 comments

In case an error occurs during loading of a context, let the Context::load() method return a boolean value indicating whether the context was successfully loaded or not. Throwing an Exception causes a false positive in debuggers,since the Context::load() method does the correct thing anyway

annexus254 avatar Aug 08 '22 15:08 annexus254

Codecov Report

Merging #384 (233788b) into 6.0.x (9b6be66) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##              6.0.x     #384      +/-   ##
============================================
- Coverage     95.20%   95.20%   -0.01%     
+ Complexity     2162     2161       -1     
============================================
  Files            66       65       -1     
  Lines          4591     4588       -3     
============================================
- Hits           4371     4368       -3     
  Misses          220      220              
Impacted Files Coverage Δ
src/Context.php 97.68% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 08 '22 15:08 codecov[bot]