sql-parser icon indicating copy to clipboard operation
sql-parser copied to clipboard

Missing mysql 8 statements

Open andrewchernow opened this issue 4 years ago • 9 comments

Any plans to add the VALUES and WITH (CTE) statements? I am in need of detecting any statement that can produce results.

andrewchernow avatar Apr 29 '21 00:04 andrewchernow

Hi, Any implementation would be very welcome :) We are open to contributions, any help on this repository would be awesome

williamdes avatar Apr 29 '21 01:04 williamdes

I wish I could. Between all my projects and work, I don't have the time. It is curious though, that mysql 8 was released 3 years ago and these new statements are still not supported? Yet, you committed 9 days ago?

andrewchernow avatar Apr 29 '21 01:04 andrewchernow

I wish I could. Between all my projects and work, I don't have the time. It is curious though, that mysql 8 was released 3 years ago and these new statements are still not supported? Yet, you committed 9 days ago?

I understand

On this repository there is some work to support new syntaxes, the code is improved but not much new features are written. I did not write the code for this repository, and you can have a look but it is not always easy to understand how the parsing works this is for me the main reason I did not start writing features here But this is for sure a topic and I hope to get this moving on in the next months

williamdes avatar Apr 29 '21 01:04 williamdes

Really? I mean, it can'y be too hard. Let me look. Maybe I can patch it to support these new statements. I am swamped but I will look at it further.

andrewchernow avatar Apr 29 '21 01:04 andrewchernow

Really? I mean, it can'y be too hard

It's not that hard but for me it's discouraging My first task when I will switch on this repository will be to change the tests output files to something readable by humans so anyone can check the diffs between objects when adding features

In fact I do not feel enough confortable about the implementing and not breaking things part of it. One very good thing is that this project has a very good code coverage and I wrote the missing tests a while ago

Conclusion: a better way to dump objects in tests and then new features

I hope this was not to much a messy explanation

williamdes avatar Apr 29 '21 02:04 williamdes

Got it. Sorry, my comment may have come off insulting. That was not my intent.

andrewchernow avatar Apr 29 '21 12:04 andrewchernow

Got it. Sorry, my comment may have come off insulting. That was not my intent.

No worries, you are just asking good questions :)

williamdes avatar Apr 29 '21 13:04 williamdes

WITH will be part of 5.5.0 Implemented in: #334

williamdes avatar May 16 '21 13:05 williamdes

This will help tests output and their changes to be understood: 9f16b246ba0752b0cbf568e469cb2559cb3ace4a

williamdes avatar May 19 '21 22:05 williamdes