phpmyadmin icon indicating copy to clipboard operation
phpmyadmin copied to clipboard

Fix text operators order

Open setaou opened this issue 10 months ago • 2 comments

Description

Restore original order for text operators, making LIKE the default instead of LIKE %...%.

Fixes #19611 Reverts #17730 / #19499

Before submitting pull request, please review the following checklist:

  • [x] Make sure you have read our CONTRIBUTING.md document.
  • [x] Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • [x] Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • [x] Every commit has a descriptive commit message.
  • [x] Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • [x] Any new functionality is covered by tests.

setaou avatar Feb 24 '25 14:02 setaou

See https://github.com/phpmyadmin/phpmyadmin/issues/19556#issuecomment-2620062424 which I think would be a better solution.

kamil-tekiela avatar Feb 24 '25 15:02 kamil-tekiela

That is a suggestion that is worth discussing, however my proposal was for now to restore the previous behavior which has been working for years for most of the users, which makes sense to me for a QA branch.

setaou avatar Feb 24 '25 15:02 setaou

@liviuconcioiu are you okay for a revert ? For me let's go and we can clean this up in a way that is not changing the default behavior

williamdes avatar Sep 14 '25 16:09 williamdes

@liviuconcioiu are you okay for a revert ? For me let's go and we can clean this up in a way that is not changing the default behavior

YES! PLEASE MERGE IT! I was about to ask for this to be merged for 5.2.3. In 6.0.0 we can do some enhancement configurable in config

liviuconcioiu avatar Sep 14 '25 17:09 liviuconcioiu