phpmyadmin icon indicating copy to clipboard operation
phpmyadmin copied to clipboard

Bugfix for changing $cfg['RepeatCells'] no effect

Open still-dreaming-1 opened this issue 3 years ago • 4 comments

Fixes changing $cfg['RepeatCells'] in configuration has no effect.

I'm not sure if this is a good way to fix this or not, but it does fix this problem for me in my local environment. I'm not sure what the purpose of checking empty($query['repeat_cells']) was in the original code.

Signed-off-by: still-dreaming-1 [email protected]

still-dreaming-1 avatar Jan 11 '23 18:01 still-dreaming-1

Actually, I thought I wanted this setting to work, but now that it does, I don't like it. I just realized the header floats at the top as I scroll down the list of results anyways, so I don't need this setting. I guess I would like to be able to disable it if it is not already disabled. I'm not sure if the original code had it disabled or stuck at the default setting of 100.

still-dreaming-1 avatar Jan 11 '23 19:01 still-dreaming-1

Thank you for this patch, we need to have a deeper look before merging this

williamdes avatar Jan 17 '23 13:01 williamdes

Yeah, I'm not sure it makes sense anymore. Maybe the setting should be removed entirely in favor of the floating header. I think it doesn't float with some of the other PhpMyAdmin themes though.

still-dreaming-1 avatar Jan 19 '23 18:01 still-dreaming-1

Let's keep it open until it's debugged :)

williamdes avatar Mar 11 '23 16:03 williamdes