phpmd icon indicating copy to clipboard operation
phpmd copied to clipboard

class NumberOfChildren has property name "minimum" that clashes with description

Open tanael opened this issue 8 years ago • 1 comments

https://github.com/phpmd/phpmd/blob/08a38d44da7865b7938dd6da860c2f44ac19b002/src/main/php/PHPMD/Rule/Design/NumberOfChildren.php#L39

It basically ends up looking like this in the ruleset xml file:

<property name="minimum" value="15" description="Maximum number of acceptable child classes." />

tanael avatar Apr 13 '18 07:04 tanael

Along the same line, I am wondering if this line is not faulty either:

https://github.com/phpmd/phpmd/blob/08a38d44da7865b7938dd6da860c2f44ac19b002/src/main/php/PHPMD/Rule/Design/DepthOfInheritance.php#L42

But I haven't tested that particular case so I might be mistaken (did not want to open a new issue w/o being sure...)

tanael avatar Apr 13 '18 07:04 tanael