arkitect icon indicating copy to clipboard operation
arkitect copied to clipboard

Add exclude root

Open notcgi opened this issue 3 months ago • 7 comments

https://github.com/phparkitect/arkitect/issues/338

notcgi avatar Mar 20 '24 04:03 notcgi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.20%. Comparing base (b78ecce) to head (44c9c17). Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #423      +/-   ##
============================================
+ Coverage     94.19%   94.20%   +0.01%     
- Complexity      582      587       +5     
============================================
  Files            69       69              
  Lines          1533     1536       +3     
============================================
+ Hits           1444     1447       +3     
  Misses           89       89              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 20 '24 08:03 codecov-commenter

Hi @notcgi can you please fix the CI?

AlessandroMinoccheri avatar Mar 20 '24 08:03 AlessandroMinoccheri

Hi @notcgi can you please fix the CI?

done

notcgi avatar Mar 20 '24 08:03 notcgi

Exclude root namsepace is not the same thing as excluding the PHP built-in classes... but anyway is a solution we can evaluate.

fain182 avatar Mar 21 '24 10:03 fain182

@notcgi when do you think is useful to exclude root classes?

AlessandroMinoccheri avatar Mar 21 '24 16:03 AlessandroMinoccheri

@notcgi when do you think is useful to exclude root classes?

Domain and Application layers can have dependencies like Datetime(-Immutable), Exception, Throwable, RuntimeException, UnitEnum etc

notcgi avatar Mar 22 '24 02:03 notcgi

Can you please also update the doc in this PR with this new possible feature please @notcgi ?

AlessandroMinoccheri avatar Mar 29 '24 13:03 AlessandroMinoccheri

Thank you @notcgi

AlessandroMinoccheri avatar Apr 30 '24 15:04 AlessandroMinoccheri