arkitect icon indicating copy to clipboard operation
arkitect copied to clipboard

simplify init

Open fain182 opened this issue 1 year ago • 6 comments

I am not sure about this one, the different includes seems redundant, without this code the CI is green... Any additional test we can make to check if this is useful?

fain182 avatar Aug 19 '22 16:08 fain182

Did you try to generate the phar file without those lines and verify that it works fine? Can we automate this check?

  • Generate phar
  • using phar with some rule with some files

AlessandroMinoccheri avatar Aug 19 '22 19:08 AlessandroMinoccheri

I tried to generate the phar (with make phar) but it failed, even on the main branch..

But if I understand correctly the github action make a smoke test on the phar: https://github.com/phparkitect/arkitect/blob/main/.github/workflows/build.yml#L116

fain182 avatar Aug 19 '22 19:08 fain182

The smoke test was done for that: test the phar generation. @micheleorselli what do you think?

AlessandroMinoccheri avatar Aug 19 '22 20:08 AlessandroMinoccheri

Which error do you get @fain182 ? It's about /tmp/.. permission, right?

AlessandroMinoccheri avatar Aug 29 '22 16:08 AlessandroMinoccheri

Which error do you get @fain182 ? It's about /tmp/.. permission, right?

the first error is:

bin/box.phar compile -c /tmp/arkitect/box.json
make: bin/box.phar: Permesso negato
make: *** [Makefile:26: phar] Errore 127

If I correct the permission, it says something strange about PHP versions... Schermata del 2022-08-30 14-33-26

fain182 avatar Aug 30 '22 12:08 fain182

Which error do you get @fain182 ? It's about /tmp/.. permission, right?

the first error is:

bin/box.phar compile -c /tmp/arkitect/box.json
make: bin/box.phar: Permesso negato
make: *** [Makefile:26: phar] Errore 127

If I correct the permission, it says something strange about PHP versions... Schermata del 2022-08-30 14-33-26

If I remember correctly, the Box version we have works fine php 7.1, which is the version we use to generate the phar. Other 7.x version should work, 8.x version will not. More recent Box version will work with php 8, but they dropped the support for php 7.1

Long story short, if you want to generate the phar you need to have php 7

micheleorselli avatar Aug 30 '22 13:08 micheleorselli