implements have name start with and ends with class expressions

[fokosun]

trafficstars

What does this PR do?

Implements two new class expressions namely: HaveNameEndingWith and HaveNameStartingWith

HaveNameEndingWith

A class expression that evaluates that the classname ends with a given string

HaveNameStartingWith

A class expression that evaluates that the classname starts with a given string

[pfazzi]

Hello @fokosun, thanks for contributing :)

At the beginning of this project we have been debating about the minimum PHP version to support and we finally agreed to maintain backward compatibility with older PHP versions, since PHP 7.1. The reason is that we want to allow people anchored in ancient PHP versions to install and run the tool easily.

Please, could you use strpos instead of new functions in order to guarantee compatibility with older PHP versions? Thansk 🙂

[fokosun]

Hello @fokosun, thanks for contributing :)

At the beginning of this project we have been debating about the minimum PHP version to support and we finally agreed to maintain backward compatibility with older PHP versions, since PHP 7.1. The reason is that we want to allow people anchored in ancient PHP versions to install and run the tool easily.

Please, could you use strpos instead of new functions in order to guarantee compatibility with older PHP versions? Thansk 🙂

got it! working on that. Thanks for the feedback

[pfazzi]

@fokosun, you should comply with coding styles. Please run make build before to push ;)

[AlessandroMinoccheri]

@fokosun thanks for this PR! I agree with @pfazzi comments and @fokosun, if you need some helps let me know.

[fokosun]

@fokosun thanks for this PR! I agree with @pfazzi comments and @fokosun, if you need some helps let me know.

Thanks

@fokosun thanks for this PR! I agree with @pfazzi comments and @fokosun, if you need some helps let me know.

Thanks @AlessandroMinoccheri 😃 for the opportunity to contribute to this package. I found it very helpful and I'm happy to make more contributions going forward. I have made the changes @pfazzi requested.

[diimpp]

Is there a reason to introduce new expressions, when HaveNameMatching('*Controller') already exists? If wildcard is not good enough, then perhaps generic regexp expression can be added

[fokosun]

Is there a reason to introduce new expressions, when HaveNameMatching('*Controller') already exists? If wildcard is not good enough, then perhaps generic regexp expression can be added

You have a valid point there! Apologies for the long delay in responding and working to address the issues on this PR. It looks like this PR is not really necessary then based on this comment. Is it okay to close the PR?

[AlessandroMinoccheri]

Ok @fokosun I close this PR but feel free to contribute again :)