phpactor icon indicating copy to clipboard operation
phpactor copied to clipboard

[WIP] Laravel Blade

Open haringsrob opened this issue 1 year ago • 3 comments

This pr is just to show the concept.

It uses the output of code written in https://github.com/haringsrob/laravel-dev-tools (a lsp on its own).

haringsrob avatar Jul 20 '22 06:07 haringsrob

so in theory you could:

https://github.com/phpactor/phpactor/blob/f679c693cb5a1734da10a58a4bcefe3c2527a759/lib/Extension/Behat/BehatExtension.php#L55-L63

you could then (in the completor):

  • change the language of the text document to "php"
  • inject the container from which you could lazily get the entire completor (needed to avoid circular dep as it has a dep on this class)

not sure if this is the best approach, it would also be, I think, required to NOT depend on Laravel if at all possible (we already depend on PHPStan + Psalm for those extensions but not sure we should)

dantleech avatar Jul 20 '22 07:07 dantleech

also nice to see that the Language Server package is used by at least one other thing :smile:

dantleech avatar Jul 20 '22 07:07 dantleech

I still have to work on this. Might do it later today to make it into a core extension.

haringsrob avatar Aug 30 '22 06:08 haringsrob

closing for now as stale, feel free to continue to discuss here

dantleech avatar Oct 02 '22 08:10 dantleech