language-server
language-server copied to clipboard
phpactor
language-server should require the pcntl extension.
Since the project uses constants predefined by the pcntl extension, it should be added to the composer.json file ("ext-pcntl": "*") as requirements. The pcntl extension is not enabled by default.
The Requirements section in phpactor README.md file should also clearly indicate that a *NIX system is required to run it (because of the pcntl extension):
Requirements
- *nix OS (Windows not supported)
- PHP 7.3+
- Composer
I was testing it on my system and lost a lot of time uselessly...
I haven't tested on Windows, in theory it could work but there are likely lots of edge cases. PNCTL should be optional.
Feel free to PR the README to add the Windows not currently supported disclaimer.
It should work regardless in WSL?
I haven't tested on Windows, in theory it could work but there are likely lots of edge cases.
I was looking for an alternative to felixfbecker/php-language-server in VSCode, since it seems a bit abandoned (latest commit was 12 Dec 2018).
I've found phpactor/vscode-phpactor extension and tried it, but it won't even start. I've patched the extension to let the server start (Windows path were not taken into account to let the server start...), and I've found that it crashes immediately on my Win10-x64.
I don't wan to pollute this issue, will start a new one 😉.
It should work regardless in WSL?
Well, this is not a "simple" requirement, and it's not so easy to setup for a lot of people... It should have a "smooth install path" on VSCode; something like: search extension, install, run.