rest-api icon indicating copy to clipboard operation
rest-api copied to clipboard

[FEATURE] POST subscriptions route

Open macolu opened this issue 5 years ago • 7 comments

Summary

Add new endpoint to add a member to a list. Fix #118

Not sure this is the way you would have done it. Anyway, I had to implement it for an urgent need, so here it is :-)

Unit test

Integration tests added.

Code style

No code style errors according to phpcs.

Other Information

Code uses methods on Repositories that are not declared with "@method" annotations. I can make another PR on Core to add missing annotations if you want.

macolu avatar Sep 01 '20 21:09 macolu

Could you rebase against master, please @macolu? :)

xh3n1 avatar Jan 25 '21 21:01 xh3n1

@xh3n1 done :)

macolu avatar Jan 29 '21 22:01 macolu

Confirmed working to add a subscriber to a single list.

ramonfincken avatar Aug 16 '21 11:08 ramonfincken

It has been a year since the start of this PR. What needs to be done to get it into rest-api core ? @macolu @xh3n1

ramonfincken avatar Aug 21 '21 09:08 ramonfincken

I'm not part of the team, so I can't go any further...

macolu avatar Aug 22 '21 06:08 macolu

@michield Can we look into this?

nfebe avatar Aug 23 '21 11:08 nfebe

@michield Can we look into this?

you need to clear cache in order to get the new /subscriptions to be recognized

hurricaneop avatar Mar 17 '22 19:03 hurricaneop