phplist3 icon indicating copy to clipboard operation
phplist3 copied to clipboard

Fix certain PR checks that always fail

Open lwcorp opened this issue 2 years ago • 7 comments

If someone tries to send a PR to your code, two commit checks always fail.

Steps to reproduce

  1. Edit a file or create a new one.
  2. Commit it.
  3. Send a PR.

Expected result Pass all checks.

Actual outcome The second and third checks from the end (7.2 and 7.3) always fail. You can see them for further details in every open PR. The important part is it has nothing to do with the PR, but presented like it is (unless one clicks Details and reads carefully).

image

lwcorp avatar Oct 05 '23 23:10 lwcorp

yes, that's why they are marked to "allow to fail". They fail on composer dependencies. We'll take them out soon

michield avatar Nov 05 '23 14:11 michield

Where does it show "allow to fail"?

lwcorp avatar Nov 05 '23 14:11 lwcorp

image

michield avatar Nov 05 '23 22:11 michield

Do only admins see it?

lwcorp avatar Nov 06 '23 13:11 lwcorp

Ah, don't know. Can you see it here? https://github.com/phpList/phplist3/actions/runs/6760239013

Also, the overall run has a blue tick, as opposed to a red one when all of them fail https://github.com/phpList/phplist3/actions

michield avatar Nov 06 '23 20:11 michield

Some actions there have a fail icon and some "just" a warning.

In #994 for example to know it's okay not to pass some of these tests?

lwcorp avatar Nov 07 '23 07:11 lwcorp

This is now ready for review in #1004

michield avatar Dec 30 '23 11:12 michield