phplist3 icon indicating copy to clipboard operation
phplist3 copied to clipboard

Fix the Rate link (which appears while editing a campaign)'s tooltip

Open lwcorp opened this issue 2 years ago • 7 comments

While editing campaigns there is a Rate link with a seemingly completely unrelated tooltip, could you fix the tooltip to explain what Rate actually does (and thus also possibly prevent accidentally clicking it)?

Steps to reproduce Create/Edit a campaign

Expected result I don't know, that's the bug report

Actual result I don't know, as I dare not click

Additional info Attempt to ask for forum support about the meaning of this option was futile.

8dc161b10f1d49a708e27fae90b8b0d8f494f09a

lwcorp avatar Oct 05 '23 21:10 lwcorp

No idea where that comes from, but I can't see that link. Is it some plugin you have installed?

michield avatar Nov 05 '23 14:11 michield

No, having just built-in plugins and they're all disabled anyway except for the default editor.

BTW, clicking Rate just deletes its own <a element and fills a very short 1 liner in the preview. The code is: <a class="ajaxable " href="./?page=send&tab=Content&id=179&action=generatetextpreview&tk=204134b306f017db96cd25f38d5ead7c" title="Create a campaign to send out to your subscribers">Rate</a>

And the language is English: c01827441f3a264f4f413dfa96ba6e0dd2e8104f

lwcorp avatar Nov 05 '23 14:11 lwcorp

This issue has been mentioned on phpList Discuss. There might be relevant details there:

https://discuss.phplist.org/t/what-is-the-rate-link-while-editing-a-campaign/9126/5

phpListDockerBot avatar Nov 05 '23 20:11 phpListDockerBot

Ah, not sure why the translation says "Rate" that's wrong, but it's created here:

https://github.com/phpList/phplist3/blob/main/public_html/lists/admin/send_core.php#L679

You can suppress it in your config file with

define('USE_MESSAGE_PREVIEW',false);

or by removing that completely, as it defaults to false

michield avatar Nov 06 '23 20:11 michield

But I do want to use this option...

lwcorp avatar Nov 07 '23 07:11 lwcorp

Ah, ok, I think the "Rate" should be "Generate" and the translation is wrong. What happens when you click it? Presumably it generates a "message preview". Sorry, I didn't write that code, so not actually sure.

michield avatar Nov 07 '23 08:11 michield

What happens when you click it? Presumably it generates a "message preview".

As mentioned earlier:

BTW, clicking Rate just deletes its own <a element and fills a very short 1 liner in the preview.

But here's a screenshot to clarify:

image

lwcorp avatar Nov 07 '23 09:11 lwcorp