phplist3 icon indicating copy to clipboard operation
phplist3 copied to clipboard

Allow Installing Zipped Plugins from Other Sites than Github

Open mmx33 opened this issue 3 years ago • 4 comments

Right now the web interface for installing plugins only allows plugins from Github. Could this limitation be removed? I personally do not want to host my plugins on Github, but I want to be able to install them over the web interface.

That's the part of the code I'm speaking of:

https://github.com/phpList/phplist3/blob/aa617dfbb9124581b49348dd69dbb171bfbc283f/public_html/lists/admin/plugins.php#L35-L41

I think removing the code would allow users to install plugins from Gitea or Gitlab instances.

mmx33 avatar Jan 11 '22 07:01 mmx33

Yes, we can add other sources. Does Gitlab have a similar system that zips the code on the fly? If so, what is the URL pattern? Then we can add Gitlab as an additional approved source.

michield avatar Jan 12 '22 19:01 michield

The code that checks for updates to plugins is specific to GitHub, function getLatestTag().

bramley avatar Jan 13 '22 10:01 bramley

Thanks, we should keep that in mind. I'm all for adding Gitlab to the mix. In fact, I've often contemplated moving the official repo to Gitlab, but I guess that's a lot of work, so we can leave that for now. Gitlab is way better on Kudos on FOSS, certainly now that Github is in MS hands.

michield avatar Jan 13 '22 21:01 michield

Ok, so if a plugin lives on Gitlab eg https://gitlab.com/michield/phplist-plugin-smtpbalancer

The zip file URL is https://gitlab.com/michield/phplist-plugin-smtpbalancer/-/archive/master/phplist-plugin-smtpbalancer-master.zip

And you can fetch the tags from https://gitlab.com/api/v4/projects/michield%2Fphplist-plugin-smtpbalancer/repository/tags

So, that seems quite possible.

michield avatar Jan 25 '22 20:01 michield

Fixed by #973

bramley avatar Nov 14 '23 10:11 bramley