TypeResolver icon indicating copy to clipboard operation
TypeResolver copied to clipboard

Change array syntax to more commonly used

Open kkmuffme opened this issue 2 weeks ago • 4 comments

  • to visually distinguish from conditional types like ($foo ? false : string[]) and callable syntax
  • to improve readability for array shapes and arrays of literals
  • to visually more closely align it with PHP native type hint

kkmuffme avatar Dec 07 '25 11:12 kkmuffme

Can you please approve the github workflow, so they run in github's CI so I know what/which if any fail, bc if I run all projects' tests locally I can't work on something else in the meantime

kkmuffme avatar Dec 07 '25 15:12 kkmuffme

No, I don't have access. We'll have to wait for @jaapio for that.

mspirkov avatar Dec 07 '25 16:12 mspirkov

Also this PR needs tests. Test coverage has never been 100% but we need to make sure we are not breaking things in the future.

jaapio avatar Dec 08 '25 19:12 jaapio

I suggest doing it like this: https://github.com/phpDocumentor/TypeResolver/pull/274

mspirkov avatar Dec 12 '25 10:12 mspirkov

I think this request can be closed because I did it in another request. @kkmuffme Thanks for the idea.

mspirkov avatar Dec 23 '25 08:12 mspirkov